feat: add Existence/runtime-validity bug-class to adversarial-design-review (#55)#56
Merged
Merged
Conversation
added 9 commits
May 31, 2026 17:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds one Existence / runtime-validity bug-class to the
adversarial-design-reviewdesign-phase checklist (inherited by the plan phase viaSKILL.md:101), closing a 2-retro gap where a review verified an artifact's intended content but never that the artifact exists or runs as the design assumed. Releases as v6.2.2.Closes #55.
Design
See:
docs/plans/2026-05-31-existence-runtime-validity-bugclass-design.md(design-phase adversarial review PASS at cycle 2: cycle 1 = 0C/2I/3m all resolved; cycle 2 = 0C/0I/1m applied).Implementation Plan
See:
docs/plans/2026-05-31-existence-runtime-validity-bugclass.md(plan-phase adversarial review PASS = 0C/0I/3m all applied; alignment-check PASS; scope locked).Scope Manifest
feat/existence-runtime-validity-bugclass-55Changes
skills/adversarial-design-review/SKILL.md: one new design-phase row. (a) For any artifact a design edits but did not create, require anls/ghexistence check before mutation (the required_secrets sweep hit a missingworkflow-registrymanifest at execution). (b) For any artifact a design emits, require verifying the consumer surface is real (smart-CI gen emittedwfctl ci run --phase migrate, no such phase). ExplicitCleanescape hatch for designs that neither edit nor emit a consumed artifact. Row count 19→20.RELEASE-NOTES.md: v6.2.2 entry..claude-plugin/plugin.json,.claude-plugin/marketplace.json,.cursor-plugin/plugin.json(merge to main auto-triggersrelease-tag.yml).Verification (evidence)
grep -c "^| \*\*" skills/adversarial-design-review/SKILL.md→ 20 (was 19); awk confirms row sits in the design-phase section.bash tests/skill-content-grep.sh→ PASS (host-neutral;wfctl/gh/ls/workflow-registryare not forbidden tokens).bash tests/version-check.sh→OK: All version files agree on version 6.2.2.bash tests/plan-scope-check.sh --verify-lock→ PASS (manifest hash intact).skill-cross-refs/skill-compression-notes→ PASS.Note
Copilot review intentionally not requested (Copilot review broken). Merge gate = adversarial-review clean + CI green.
Generated by the implementing agent.